Re: "make install-swig-{pl,py}" implies "make install" for some libraries (Issue 2126)

On Saturday 22 January 2005 01:58, Josh Lauricha wrote:
> On Fri 01/21/05 23:16, Max Bowsher wrote:
> > Justin Erenkrantz wrote:
> > >--On Friday, January 21, 2005 9:49 PM +0000 Max Bowsher <maxb@ukf.net>
> > >
> > >wrote:
> > >>If I run "make install-some-additional-feature", I expect
> > >>"some-additional-feature" to be installed. I don't expect
> > >>"some-additional-feature", and some _subset_ of the base package to be
> > >>installed.
> > >
> > >IMHO, there's two legitimate viewpoints on this:
> > >
> > >1) install dependencies
> > >2) do not install dependencies
> > >
> > >We originally did #2, but had a significant number of bug reports asking
> > >us
> > >to do #1. So, we modified the make system to install those dependencies
> > >as
> > >well - because people claimed that they expected
> > > 'some-additional-feature' to be all that was necessary to install that
> > > additional feature. (They didn't want to run 'make install.')
> > >
> > >*shrug*
> > >
> > >I think we're in a no-win situation here. So, I'm against changing it
> > > one more time: whatever we do is going to get complaints. Best to
> > > leave it as it is. -- justin
> >
> > I'm for changing it again, because:
>
> Though your points are valid, why not have:
> make install
> make install-foo (which will do make install)
> make install-pkg-foo (wont do make install)
>
> Allowing everyone to be happy, install-foo would be something like:
> install-foo: install install-pkg-foo
>
> so its not that much more in terms of code, unless I'm missing
> something.

Such a solution would be perfectly acceptable by me. However, at the moment,
the entry for make install-swig-pl-lib looks something like that:

<<<
install-swig-pl-lib: \
subversion/bindings/swig/perl/libsvn_swig_perl/libsvn_swig_ \
perl-1.la ***install-fsmod-lib***
        $(MKDIR) $(DESTDIR)$(swig_pl_libdir)
        cd subversion/bindings/swig/perl/libsvn_swig_perl ;
$(INSTALL_SWIG_PL_LI
B) libsvn_swig_perl-1.la $(DESTDIR)$(swig_pl_libdir)/libsvn_swig_perl-1.la
>>>

So there is no choice but to run install-fsmod-lib.

Regards,

        Shlomi Fish

-- 
---------------------------------------------------------------------
Shlomi Fish      shlomif@iglu.org.il
Homepage:        http://www.shlomifish.org/
Knuth is not God! It took him two days to build the Roman Empire.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org