[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: mailer.py now should work on Windows - soliciting testers (furtherinformation)

From: Max Bowsher <maxb_at_ukf.net>
Date: 2005-01-11 14:33:09 CET

Nicklas Norling wrote:
>> Max Bowsher wrote:
>> <snip>
>>
>>> I have now backported the changes to the 1.1.x mailer.py, thus
>>> rendering the complexities alluded to in the above paragraph
>>> unnecessary.
>>>
>>> The script may be found at:
>>> http://svn.collab.net/repos/svn/branches/1.1.x-mailer.py/tools/hook-scripts/mailer/
>>>
>>>
>>>
>>> Max.
>>
>> Thanks a lot Max, that is very much appreciated!
>> /Nicke
>>
>
> Ok, here are some feedback from my tests.
>
> First the script and it's conf.example is in unix eol-style. I suppose
> setting svn:eol-style=native would be a good idea here? Maybe this should
> be done on more scripts/configs like this (unrelated to this though)?

I'd have to test if it still reads it's config properly - I think it should,
though.
Then, yes eol-style native should be set.

> After some modifications to the hook templates I finally could run it but
> it did not send out any mail. I was unable to find any way of debugging
> this (is something logged somewhere?).

As you figured out, just do a dry-run.

> Looking at the description of the
> command parameters I attempted the following dry run:
>
> E:\Svnrepo\Test1\hooks>post-commit.cmd E:\Svnrepo\Test1 19
>
> E:\Svnrepo\Test1\hooks>mailer.py commit "E:\Svnrepo\Test1" 19
> Traceback (most recent call last):
...
> AttributeError: 'module' object has no attribute 'argv_to_command_string'
>
> I have created a test repo Test1 at the path E:\Svnrepo\Test1. I've just
> committed revision 19 to it before I ran the script.
> I realize I probably did something silly but can't understand what.

No, that would be my fault. Thanks for testing and discovering my oversight.

Fix applied in r12670.

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jan 11 14:35:45 2005

This is an archived mail posted to the Subversion Dev mailing list.