[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: mailer.py now should work on Windows - soliciting testers (furtherinformation)

From: Nicklas Norling <exinor_at_exinor.net>
Date: 2005-01-11 12:40:35 CET

> Max Bowsher wrote:
> <snip>
>
>> I have now backported the changes to the 1.1.x mailer.py, thus
>> rendering the complexities alluded to in the above paragraph
>> unnecessary.
>>
>> The script may be found at:
>> http://svn.collab.net/repos/svn/branches/1.1.x-mailer.py/tools/hook-scripts/mailer/
>>
>>
>>
>> Max.
>
> Thanks a lot Max, that is very much appreciated!
> /Nicke
>

Ok, here are some feedback from my tests.

First the script and it's conf.example is in unix eol-style. I suppose
setting svn:eol-style=native would be a good idea here? Maybe this should
be done on more scripts/configs like this (unrelated to this though)?

After some modifications to the hook templates I finally could run it but
it did not send out any mail. I was unable to find any way of debugging
this (is something logged somewhere?). Looking at the description of the
command parameters I attempted the following dry run:

E:\Svnrepo\Test1\hooks>post-commit.cmd E:\Svnrepo\Test1 19

E:\Svnrepo\Test1\hooks>mailer.py commit "E:\Svnrepo\Test1" 19
Traceback (most recent call last):
  File "D:\Program Files\Subversion\bin\mailer.py", line 748, in ?
    author, propname)
  File "D:\Python\lib\site-packages\svn\core.py", line 33, in run_app
    return apply(func, (pool,) + args, kw)
  File "D:\Program Files\Subversion\bin\mailer.py", line 50, in main
    messenger.generate()
  File "D:\Program Files\Subversion\bin\mailer.py", line 316, in generate
    group, params, subpool)
  File "D:\Program Files\Subversion\bin\mailer.py", line 371, in
generate_content
    generate_diff(output, cfg, repos, date, change, group, params, pool)
  File "D:\Program Files\Subversion\bin\mailer.py", line 531, in
generate_diff
    output.run(cfg.get_diff_cmd({
  File "D:\Program Files\Subversion\bin\mailer.py", line 117, in run
    pipe_ob = Popen4(cmd)
  File "D:\Program Files\Subversion\bin\mailer.py", line 80, in __init__
    cmd = svn.core.argv_to_command_string(cmd)
AttributeError: 'module' object has no attribute 'argv_to_command_string'

I have created a test repo Test1 at the path E:\Svnrepo\Test1. I've just
committed revision 19 to it before I ran the script.
I realize I probably did something silly but can't understand what.

/Nicke

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jan 11 12:41:36 2005

This is an archived mail posted to the Subversion Dev mailing list.