Re: svn commit: r12465 - in trunk/subversion: clients/cmdline include libsvn_client tests/clients/cmdline

Philip Martin <philip@codematters.co.uk> writes:
> Look again, the logic is the other way round, it only clears
> WC_NOT_DIRECTORY.

Ack, sorry about that.

> > I would expect the reverse logic: clear a certain specific set of
> > errors -- those that are legitimate reasons for skipping a file, such
> > as that the item is unversioned -- and return all other errors.
>
> :)

Uh, yes... "<grin>" :-).

> > In any case, looking at the above code, and comparing with the test
> > results I quoted earlier, I'm baffled as to how it could be reporting
> > "At revision 12471" for the unversioned targets. It should give a
> > "Skipped" notification, right?
>
> It's in the docstring. versioned/unversioned doesn't skip, you get a
> skip with unversioned/unversioned.
>
> I did expect versioned/unversioned to give an error if unversioned
> didn't get added, but that's not the way the update editor works. As
> far as I know I didn't change anything here.

Okay. I had thought the old current was different, but I didn't have
an old client to test with and didn't have time to build one. I'll
try when I go home, before I update there.

> I don't really care, but given that you misuderstood what I wrote I'll
> change it and add a comment :)

Oh, I'm perfectly capable of misunderstanding it the new way too,
don't change it on that account :-).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Dec 21 03:42:25 2004