[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r12304 - in trunk/notes/locking: . old

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2004-12-14 02:49:33 CET

On Dec 13, 2004, at 4:51 PM, Peter N. Lundblad wrote:
>>
>> +RA->unlock()
>> +
>> + * send http UNLOCK request with 1 custom header:
>> +
>> + - force flag
>> +
>> + * mod_dav_svn should call authz_read func on path, if it exists.
>> +
>> + * generate http UNLOCK response: success == "204 no content"
>> +
>> + - has one custom response header: creation-date
>> +
> What's the point of this response header?

Whoops, it's a copy-and-paste bug. :-) There's no point.

>
>> + * what if older server? just returns '405 Method not Allowed'.
> Those will be translated into SVN_ERR_RA_NOT_IMPLEMENTED.

Um, I suppose so. Do we already do this throughout ra_dav? I don't
think we do...

>
>> +RA->get_commit_editor2()
>> +
>> + * stash the incoming hash of tokens.
>> +
>> + * every time we do a CHECKOUT or PUT of a file path, look to see
>> + if there's a token available in the hash. If so, put it in
>> the
>> + If: header of the request.
>> +
>> + * send *all* tokens in the If: header of the final MERGE
>> request.
>> +
> How do you handle keep_locks? Separate UNLOCK requests? Or something
> extra
> for the final MERGE?
>

That's a question I've not figured out yet. I guess we should marshall
the 'keep_locks' boolan to mod_dav_svn, so that it can potentially
release locks after the commit succeeds.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Dec 14 02:50:54 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.