Re: [PATCH] Add --revprop support to svnlook

Oliver Klozoff wrote:
> 1. Should I provide the test as a patch to svnlook_tests.py, or just
> give the routine?

Please provide it as a patch, as this makes it easy for someone else to apply
and test and commit it.

> 2. Should the patch be included as part of my main patch, or should I
> write two patches (one for svnlook/main.c, and one for svnlook_tests.py)?

Preferably include the test as part of your main patch, but if that would mean
delaying the main patch by a very long time then you could do the main patch
first and add the test as a separate patch afterwards.

> 3. While I'm at it, I think I should write some testcases for the other
> svnlook features -- svnlook has 14 subcommands (other than 'help') and
> only three tests.
> If I do, should I create individual patches for those tests, or just
> build one big new-tests-for-svnlook patch?

It doesn't really matter. It is certainly OK for the new tests to be grouped
in a single commit, regarded as related parts of a single enhancement.

Thank you for offering to write regression tests. They are very useful.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 13 16:10:06 2004