Re: [PATCH] Add --revprop support to svnlook

Philip Martin wrote:

> Have you looked at the regression tests? Could you write a basic
> "this feature works" test? Take a look at the existing tests in
> subversion/tests/clients/cmdline/svnlook_tests.py

Okay, a few more questions:

1. Should I provide the test as a patch to svnlook_tests.py, or just give the
routine?

2. Should the patch be included as part of my main patch, or should I write two
patches (one for svnlook/main.c, and one for svnlook_tests.py)?

3. While I'm at it, I think I should write some testcases for the other svnlook
features -- svnlook has 14 subcommands (other than 'help') and only three tests.
If I do, should I create individual patches for those tests, or just build one
big new-tests-for-svnlook patch?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Dec 11 01:53:21 2004