Re: Control characters in log message cause failure

"Peter N. Lundblad" <peter@famlundblad.se> writes:
> > So the code should be:
> >
> > /* sending a log msg from server to client */
> >
> > if (is_valid_utf8 (msg) && svn_xml_is_xml_safe (msg))
> > {
> > send_message (escape_xml (msg));
> > }
> > else
> > {
> > send_message (fuzzy_escape (msg));
> > }
> >
> Now you're near:-) svn_xml_is_xml_safe doesn't allow UTF8 outside of ASCII
> today. The UTF8 validation should be integrated in that function, else you
> will fuzzify my Swedish log messages:-( Då får du ingen räksmörgås...

MBK's suggestion takes care of all of this of course, but good point.

So, who's gonna code it? (IOW, who's gonna fix issue #2147?)

I'm deeply embedded in #2106 right now, and I'd like to stick to the
1.2 scalability issues while I've got my mind in that mode. So I
don't want to jump to #2147. But I think it's easily resolveable now.
MBK, want to have a try? Julian? Peter? Mary-Anne? Ginger? Professor?

:-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 2 20:25:00 2004