On Thu, 1 Dec 2004 kfogel@collab.net wrote:
> "Peter N. Lundblad" <peter@famlundblad.se> writes:
> > > Seriously, I've hand-waved on that detail. I was assuming could add
> > > an encoding attribute (I think we do that already).
> > >
> > We use the DAV element comment (in the DAV namespace) for the log message.
> > There is no encoding there, if we're talking about the XML used in the svn
> > log command.
>
> So the code should be:
>
> /* sending a log msg from server to client */
>
> if (is_valid_utf8 (msg) && svn_xml_is_xml_safe (msg))
> {
> send_message (escape_xml (msg));
> }
> else
> {
> send_message (fuzzy_escape (msg));
> }
>
Now you're near:-) svn_xml_is_xml_safe doesn't allow UTF8 outside of ASCII
today. The UTF8 validation should be integrated in that function, else you
will fuzzify my Swedish log messages:-( Då får du ingen räksmörgås...
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 2 20:16:57 2004