[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: issue #1954

From: Branko Čibej <brane_at_xbc.nu>
Date: 2004-12-02 09:28:18 CET

Julian Foad wrote:

> kfogel@collab.net wrote:
>
>> Valid Subversion paths are UTF8 strings, but with no control chars
>> allowed except for TAB.
>
>
> This is now sounding like a very good proposal.
>
> Let me just stick my neck out and ask, quoting C-Mike Pilato, "GACK!
> Exceptions! Why in Heaven's name must there always be exceptions?!"
> Not this this necessarily deserves such a strong reaction, but it's
> always worth asking ourselves this question.
>
> Is there any known substantial reason for allowing TAB? I know it's
> easy enough to allow it, and some people might have file names with
> TAB in them ... but I'd like a stronger reason such as evidence that
> people actually do have such file names (and not just in those weird
> cases where they also have other control characters). Another strong
> reason could be compatibility with some existing filename standard.
>
> If there is no strong reason, then I would suggest not allowing TAB.
> As I keep saying recently, it's very easy to relax a requirement in
> future if the need arises, whereas it is hard to tighten it.

Not allowing tabs would also simplify the validity test to the point of

    svn_ctype_isutf8(c) && !svn_ctype_iscntrl(c)

And I can add a macro that'll do this in a /single/ lookup into
svn_ctype_table. :-)

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 2 10:06:57 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.