[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r12063 - in trunk/subversion: libsvn_ra_svn svnserve

From: <kfogel_at_collab.net>
Date: 2004-11-29 21:09:43 CET

"Peter N. Lundblad" <peter@famlundblad.se> writes:
> The reason to use subpools here is to save memory when doing large edits.
> When the file/dir is closed, the subpool is destroyed. There is no reason
> to keep the path around any longer either.

That makes sense to me (though entry->pool is sort of orthogonal to a
subpool, so I'm not sure how much it should be treated like one.)

You had already seen Greg Hudson's response when you wrote this, or
not?

> I'm pretty sure this is an oversight. I considered changing it, but did
> want to keep the whole change minimal for back-porting.

Understood. I agree it should be a separate change, if it is changed.

> What about adding something like "Paths should be in canonical form when
> sent over the protocol. However, as a matter of input validation, a
> protocol implementation should always canonicalize received paths if it
> needs them in canonical form internally." You could probably word it
> better, but you get the idea.

I like your wording, actually. Go for it...

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 29 21:14:09 2004

This is an archived mail posted to the Subversion Dev mailing list.