[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r12063 - in trunk/subversion: libsvn_ra_svn svnserve

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2004-11-29 21:18:24 CET

On Mon, 2004-11-29 at 15:01, Peter N. Lundblad wrote:
> > > + path = svn_path_canonicalize(path, entry->pool);

> > Just curious: why is it better to use entry->pool here instead of
> > pool? I've no reason to think it's wrong, would just like to
> > understand better.

> The reason to use subpools here is to save memory when doing large edits.
> When the file/dir is closed, the subpool is destroyed. There is no reason
> to keep the path around any longer either.

This argument doesn't make sense. The caller is already using a subpool
which is cleared between invocations of editor commands. "pool" is a
much better choice for temporary allocations than entry->pool, which may
live considerably longer.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 29 21:24:16 2004

This is an archived mail posted to the Subversion Dev mailing list.