[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r12038 - in trunk/subversion: clients/cmdline include libsvn_client tests/clients/cmdline

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2004-11-25 22:22:42 CET

On Thu, 25 Nov 2004, Philip Martin wrote:

> lundblad@tigris.org writes:
>
> > + stdout, stderr = svntest.main.run_svn(None, 'diff', '-r1:2', iota_path,
> > + '--force')
> > +
> > + for line in stdout:
> > + if (re_nodisplay.match(line)):
> > + raise svntest.Failure
> > +
> > + stdout, stderr = svntest.main.run_svn(None, 'diff', '-r2:1', iota_path,
> > + '--force')
> > +
> > + for line in stdout:
> > + if (re_nodisplay.match(line)):
> > + raise svntest.Failure
> > +
> > + stdout, stderr = svntest.main.run_svn(None, 'diff', '-r2:3', iota_path,
> > + '--force')
> > +
> > + for line in stdout:
> > + if (re_nodisplay.match(line)):
> > + raise svntest.Failure
>
> Those are rather fragile tests as they test for the absence of a
> particular error text. If the error message changes, or if you have
> made a typo, they could pass erroneously. It might be better to test
> for the presence of some diff output, perhaps using check_diff_output.
>
I'll take a look at that. Thanks for the pinter.

> I also gets lots of these:
>
> ../svn/subversion/include/svn_client.h:965: warning: redundant redeclaration of 'svn_client_diff_peg'
> ../svn/subversion/include/svn_client.h:952: warning: previous declaration of 'svn_client_diff_peg' was here
>
Ooops! Copy-twice. Fixed in r12040.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 25 22:12:38 2004

This is an archived mail posted to the Subversion Dev mailing list.