[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r12038 - in trunk/subversion: clients/cmdline include libsvn_client tests/clients/cmdline

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2004-11-25 21:56:27 CET

lundblad@tigris.org writes:

> Author: lundblad
> Date: Thu Nov 25 14:33:32 2004
> New Revision: 12038

> + stdout, stderr = svntest.main.run_svn(None, 'diff', '-r1:2', iota_path,
> + '--force')
> +
> + for line in stdout:
> + if (re_nodisplay.match(line)):
> + raise svntest.Failure
> +
> + stdout, stderr = svntest.main.run_svn(None, 'diff', '-r2:1', iota_path,
> + '--force')
> +
> + for line in stdout:
> + if (re_nodisplay.match(line)):
> + raise svntest.Failure
> +
> + stdout, stderr = svntest.main.run_svn(None, 'diff', '-r2:3', iota_path,
> + '--force')
> +
> + for line in stdout:
> + if (re_nodisplay.match(line)):
> + raise svntest.Failure

Those are rather fragile tests as they test for the absence of a
particular error text. If the error message changes, or if you have
made a typo, they could pass erroneously. It might be better to test
for the presence of some diff output, perhaps using check_diff_output.

I also gets lots of these:

../svn/subversion/include/svn_client.h:965: warning: redundant redeclaration of 'svn_client_diff_peg'
../svn/subversion/include/svn_client.h:952: warning: previous declaration of 'svn_client_diff_peg' was here

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 25 21:57:59 2004

This is an archived mail posted to the Subversion Dev mailing list.