Re: error without message from svn_subst_translate_string

On Sat, 20 Nov 2004, SteveKing wrote:

> While fixing a crash in TSVN I found that svn_subst_translate_string()
> doesn't return a message with the error baton if the lineendings in the
> passed string are inconsistent. This leads of course then to an empty
> error dialog in TSVN.
>
> May I ask to add an error message string there? Something like
> "inconsistent lineendings"?
>
> err->message is NULL too. So nothing to show the user why the function
> failed.
>
No, err->message can be NULL, in which case the general error message
should be used. See print_error in libsvn_subr/error.c for how this is
done in the command line client. This is so that we don't have to repeat
the general error everywhere if there is no extra info to provide.

This is documented in svn_error.h, but it could be said in the docstring
for svn_error_t as well for clarity.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Nov 20 12:12:09 2004