[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

error without message from svn_subst_translate_string

From: SteveKing <steveking_at_gmx.ch>
Date: 2004-11-20 10:16:53 CET

Hi,

While fixing a crash in TSVN I found that svn_subst_translate_string()
doesn't return a message with the error baton if the lineendings in the
passed string are inconsistent. This leads of course then to an empty
error dialog in TSVN.

May I ask to add an error message string there? Something like
"inconsistent lineendings"?

Steps to reproduce:

svn_string_t* pval;
pval = svn_string_create("value1\r\r\nvalue2\r\r\nvalue3", pool);
err = svn_subst_translate_string(%pval, pval, NULL, pool);

After this, err is not NULL (which means an error occurred), but
err->message is NULL too. So nothing to show the user why the function
failed.

In case you're wondering how those inconsistent lineendings came up:

a user wrote a little script to list all the properties of a folder like
this:
for %i in (foo) do @svn proplist %i -v >proplist.txt
After that, the file proplist.txt contains a list of properties of the
folder foo, but has those inconsistent lineendings in it. Now with a
simple copy-paste operation those inconsistend lineendings ended up in
TSVN to set the same properties on another folder.

All this happens with version 1.1.1 of the Subversion library.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Nov 20 10:17:59 2004

This is an archived mail posted to the Subversion Dev mailing list.