[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r11892 - in trunk/subversion: libsvn_delta libsvn_diff libsvn_ra_dav libsvn_ra_local libsvn_subr libsvn_wc

From: Branko Čibej <brane_at_xbc.nu>
Date: 2004-11-14 22:10:30 CET

Julian Foad wrote:

> Branko Čibej wrote:
>
>> julianfoad@tigris.org wrote:
>>
>>> Modified: trunk/subversion/libsvn_subr/config_impl.h
>>> Url:
>>> http://svn.collab.net/viewcvs/svn/trunk/subversion/libsvn_subr/config_impl.h?view=diff&rev=11892&p1=trunk/subversion/libsvn_subr/config_impl.h&r1=11891&p2=trunk/subversion/libsvn_subr/config_impl.h&r2=11892
>>>
>>> ==============================================================================
>>>
>>> --- trunk/subversion/libsvn_subr/config_impl.h (original)
>>> +++ trunk/subversion/libsvn_subr/config_impl.h Sat Nov 13
>>> 21:42:25 2004
>>> @@ -26,7 +26,6 @@
>>>
>>> #include <apr_hash.h>
>>> #include "svn_types.h"
>>> -#include "svn_pools.h"
>>> #include "svn_string.h"
>>> #include "svn_config.h"
>>> #include "svn_private_config.h"
>>>
>>>
>> This change breaks the build on Windows becahse config_win.c doesn't
>> include svn_pools.h, but does use functions declared in that header.
>> It may not show up on Unix, but Windows does some name mangling even
>> for C that doesn't work right without the declarations.
>
>
> Sorry about that. Does this change make the whole thing build?

It does, and I already committed something almost exactly the same. :-)

>> Please be more careful when making such sweeping changes, and check
>> where the declarations are used before removing includes from
>> headers. A build isn't enough, you have to grep through the code
>> because of various ifdefs.
>
>
> I'll try to be more careful.

Sorry if I sounded a bit undiplomatic. I understand it's not easy to
catch problems like this if you don't actually have all build systems
available. But well, you did take this non-trivial task upon yourself. :-)

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Nov 14 22:10:40 2004

This is an archived mail posted to the Subversion Dev mailing list.