[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r11892 - in trunk/subversion: libsvn_delta libsvn_diff libsvn_ra_dav libsvn_ra_local libsvn_subr libsvn_wc

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2004-11-14 22:07:01 CET

Branko Čibej wrote:
> julianfoad@tigris.org wrote:
>
>> Modified: trunk/subversion/libsvn_subr/config_impl.h
>> Url:
>> http://svn.collab.net/viewcvs/svn/trunk/subversion/libsvn_subr/config_impl.h?view=diff&rev=11892&p1=trunk/subversion/libsvn_subr/config_impl.h&r1=11891&p2=trunk/subversion/libsvn_subr/config_impl.h&r2=11892
>>
>> ==============================================================================
>>
>> --- trunk/subversion/libsvn_subr/config_impl.h (original)
>> +++ trunk/subversion/libsvn_subr/config_impl.h Sat Nov 13 21:42:25
>> 2004
>> @@ -26,7 +26,6 @@
>>
>> #include <apr_hash.h>
>> #include "svn_types.h"
>> -#include "svn_pools.h"
>> #include "svn_string.h"
>> #include "svn_config.h"
>> #include "svn_private_config.h"
>>
>>
> This change breaks the build on Windows becahse config_win.c doesn't
> include svn_pools.h, but does use functions declared in that header. It
> may not show up on Unix, but Windows does some name mangling even for C
> that doesn't work right without the declarations.

Sorry about that. Does this change make the whole thing build?

Index: subversion/libsvn_subr/config_win.c
===================================================================
--- subversion/libsvn_subr/config_win.c (revision 11897)
+++ subversion/libsvn_subr/config_win.c (working copy)
@@ -36,6 +36,7 @@
  #include "svn_error.h"
  #include "svn_path.h"
  #include "svn_utf.h"
+#include "svn_pools.h"

  svn_error_t *
  svn_config__win_config_path (const char **folder, int system_path,

I'll commit it if so.

> Please be more careful when making such sweeping changes, and check
> where the declarations are used before removing includes from headers. A
> build isn't enough, you have to grep through the code because of various
> ifdefs.

I'll try to be more careful.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Nov 14 22:07:23 2004

This is an archived mail posted to the Subversion Dev mailing list.