[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r11783 - trunk/subversion/svnserve

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2004-11-09 20:25:25 CET

On Tue, 9 Nov 2004, Philip Martin wrote:

> Branko Œibej <brane@xbc.nu> writes:
>
> > lundblad@tigris.org wrote:
> >
> >> apr_socket_listen(sock, 7);
> >>+
> >>+ /* svn_cmdline_init() sets up the locale, but when we serve clients, we
> >>+ always want the "C" locale. */
> >>+ if (!setlocale (LC_ALL, "C"))
>
> Yuck! You are forcing the user to use plain ASCII for the --root
> path, and that's not really acceptable. On Unix systems setting
> LC_MESSAGES is probably what you want, I don't know about Windows.
>
You're right. And worse, our UTF8 routines think that they should convert
to/from a character set, but that's not true after teh switch. The reason
I didn't say LC_MESSAGES is that svnserve uses some C library functions
that are affected by the LC_CTYPE locale (isalpha, isdigit, isalnum and
possibly others). I don't know if this is a real problem. If so, we should
add LC_CTYPE as well. I'll change to LC_MESSAGES in any case.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 9 20:15:33 2004

This is an archived mail posted to the Subversion Dev mailing list.