[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: crash when fetching status

From: Ben Reser <ben_at_reser.org>
Date: 2004-11-05 15:17:46 CET

On Tue, Nov 02, 2004 at 07:44:38PM +0100, SteveKing wrote:
> Hi,
>
> During the last two days, I received four crashreports from TSVN users.
> The crashreport showed a crash (EXCEPTION_ACCESS_VIOLATION) in
> libsvn_wc/status.c line 978. (Always referring to the 1.1.1 tag!)
>
> The lines in question:
> if (parent_status
> && (parent_status->text_status != svn_wc_status_unversioned)
> && (parent_status->text_status != svn_wc_status_deleted)
> && (parent_status->text_status != svn_wc_status_missing)
> && (parent_status->text_status != svn_wc_status_obstructed)
> && (parent_status->entry->kind == svn_node_dir)
> && (eb->descend || (! pb)))
> {
>
> Please check the second last line here:
> && (parent_status->entry->kind == svn_node_dir)
>
> Obviously, the
> parent_status->entry
> is NULL, which can be NULL for non-versioned items (AFAIR).

Uhh yeah but if something is unversioned the second line of that if
statement should be being hit.

So reasonably the real question here is why is something that is
unversioned not getting svn_wc_status_unversioned? Fixing that may fix
other bugs. Applying your workaround doesn't improve correctness, it
simply stops your crash.

While your crash is important, long term maintainability and usability
are better served by finding the correct solution.

This is one of the cases where you have the following scenario:
short term: bad
long term: good

vs

short term: good
long term: bad

Most people are inclined to take the good now and worry about the bad
later.

-- 
Ben Reser <ben@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 5 15:18:13 2004

This is an archived mail posted to the Subversion Dev mailing list.