[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

crash when fetching status

From: SteveKing <steveking_at_gmx.ch>
Date: 2004-11-02 19:44:38 CET

Hi,

During the last two days, I received four crashreports from TSVN users.
The crashreport showed a crash (EXCEPTION_ACCESS_VIOLATION) in
libsvn_wc/status.c line 978. (Always referring to the 1.1.1 tag!)

The lines in question:
   if (parent_status
       && (parent_status->text_status != svn_wc_status_unversioned)
       && (parent_status->text_status != svn_wc_status_deleted)
       && (parent_status->text_status != svn_wc_status_missing)
       && (parent_status->text_status != svn_wc_status_obstructed)
       && (parent_status->entry->kind == svn_node_dir)
       && (eb->descend || (! pb)))
     {

Please check the second last line here:
       && (parent_status->entry->kind == svn_node_dir)

Obviously, the
parent_status->entry
is NULL, which can be NULL for non-versioned items (AFAIR).

I think this should be instead:
   if (parent_status
       && (parent_status->entry)
       && (parent_status->text_status != svn_wc_status_unversioned)
       && (parent_status->text_status != svn_wc_status_deleted)
       && (parent_status->text_status != svn_wc_status_missing)
       && (parent_status->text_status != svn_wc_status_obstructed)
       && (parent_status->entry->kind == svn_node_dir)
       && (eb->descend || (! pb)))
     {

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 2 19:45:45 2004

This is an archived mail posted to the Subversion Dev mailing list.