[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r11750 - branches/locking/subversion/include

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2004-11-05 05:50:45 CET

On Thu, 2004-11-04 at 23:29, Ben Collins-Sussman wrote:
> Unfortunately, it's still more complicated than that. A whole slew of
> fs functions -- not just the new lock/unlock funcs -- need to check if
> locks exist before changing a path.

We're not doing that by lock token? I'm confused.

> Maybe we don't need to have this abstract svn_fs_user_t thing that
> brane proposed, though. We could simplify by just attaching a (const
> char *)username to an fs_t, and leave it at that.

That would be my preference. It would only require updating one API to
change that to an opaque user object, should the need arise.

(Updating APIs really isn't that painful. But if we overengineer
something without thinking about it carefully and then find out that we
went in the wrong direction, that's painful.)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 5 05:51:06 2004

This is an archived mail posted to the Subversion Dev mailing list.