[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Fwd: failure notice (I'm pissed now)

From: <kfogel_at_collab.net>
Date: 2004-10-31 01:27:38 CEST

"Erik Huelsmann" <e.huelsmann@gmx.net> writes:
> Ok, now you really pissed me off:
>
> - your tigris account is *not* xsteve
> - your e-mail address in COMMITTERS is *not* valid
> - psvn.el *does* contain your name and e-mail address
> - looking at psvn.el logs after my previous post: you have been committing
> patches written by others stating only their names, not e-mail addresses,
> while we normally *do* do that in this project
>
> *All* of the above is in violation with project procedure or ethics.
>
> One more thing -if that's at all possible- and I'll have to propose commit
> access revocation.

Oooh, ouch :-).

This might be a *bit* harsh, Erik, although I agree with the some of
content of what you are saying. But not all. Note that:

  1. Quite a few of our contributed scripts have the author's name and
     email addresses in them. We've been okay with that, because they
     really are developed in a different way than the rest of
     Subversion. (The "territoriality cost" is lower, while the
     "contactability" benefit is arguably higher.)

  2. Yes, we want the tigris account name to be the same as the SVN
     committer name. But it would be reasonable to blame me, or
     whoever, for not having noticed the discrepancy, since we were
     the ones who set up the SVN commit account. (The requirement was
     not even documented until fairly recently, as I recall.)

  3. We haven't been perfectly consistent about including the email
     addresses as well as the names of contributors whose patches we
     apply. If Stefan was simply using the logs as an example, he
     could have been guided either way. Sure, *most* contribution
     commits include an email address, but check out r10889, r10791,
     r10773, r10690, r10389, r10217, r9894... among many others.

     We simply cannot get mad at Stefan for failing to follow an
     undocumented guideline that was always inconsistently applied.

The core of your complaint is about log formatting, and I agree Stefan
should start formatting the log messages in the usual style (and fix
the old ones). However, this hardly rises to the level of commit
access revocation -- and the fact that his mail bounced doesn't
amplify the offense, even if it did make your life a bit inconvenient.

Stefan, could you please fix your email address in COMMITTERS, fix up
this log message, and fix up previous log messages?

Thanks,
-Karl

> --- Weitergeleitete Nachricht / Forwarded Message ---
> Date: 30 Oct 2004 21:22:55 -0000
> From: MAILER-DAEMON@mail.gmx.net
> To: e.huelsmann@gmx.net
> Subject: failure notice
>
> Hi. This is the qmail-send program at mail.gmx.net.
> I'm afraid I wasn't able to deliver your message to the following addresses.
> This is a permanent error; I've given up. Sorry it didn't work
> out.
>
> <reichoer@web.de>:
> 217.72.192.149_does_not_like_recipient./Remote_host_said:_550_<reichoer@web.de>_Benutzer_hat_zuviele_Mails_auf_dem_Server._/_User_has_too_many_messages_on_the_server./Giving_up_on_217.72.192.149./
>
> --- Below this line is a copy of the message.
>
> Return-Path: <e.huelsmann@gmx.net>
> Received: (qmail 6430 invoked by uid 0); 30 Oct 2004 21:22:53 -0000
> Received: from 81.207.235.199 by www20.gmx.net with HTTP;
> Sat, 30 Oct 2004 23:22:53 +0200 (MEST)
> Date: Sat, 30 Oct 2004 23:22:53 +0200 (MEST)
> From: "Erik Huelsmann" <e.huelsmann@gmx.net>
> To: Stefan =?ISO-8859-1?Q?Reich=F6r?= <reichoer@web.de>,
> xsteve@tigris.org
> MIME-Version: 1.0
> References: <15391.1099169089@www20.gmx.net>
> Subject: Fwd: Re: svn commit: r11672 - trunk/contrib/client-side/psvn
> X-Priority: 3 (Normal)
> X-Authenticated: #3755821
> Message-ID: <7207.1099171373@www20.gmx.net>
> X-Mailer: WWW-Mail 1.6 (Global Message Exchange)
> X-Flags: 0001
> Content-Type: text/plain; charset="iso-8859-1"
> Content-Transfer-Encoding: 8bit
>
> Peter Lundblad points out you may not be on dev@, so I'm forwarding to your
> tigris and private accounts.
>
> bye,
>
> Erik.
>
> --- Weitergeleitete Nachricht / Forwarded Message ---
> Date: Sat, 30 Oct 2004 22:44:49 +0200 (MEST)
> From: "Erik Huelsmann" <e.huelsmann@gmx.net>
> To: dev@subversion.tigris.org
> Subject: Re: svn commit: r11672 - trunk/contrib/client-side/psvn
>
> Stefan,
>
> On Sat, 30 Oct 2004 14:45:00 -0500, xsteve@tigris.org <xsteve@tigris.org>
> wrote:
> > Author: xsteve
> > Date: Sat Oct 30 14:45:00 2004
> > New Revision: 11672
> >
> > Modified:
> > trunk/contrib/client-side/psvn/psvn.el
> > Log:
> > Some patches from Richard Lewis
> >
> > * trunk/contrib/client-side/psvn/psvn.el:
> > - (svn-status-use-history) Report the error when we chose a
> non-directory
> > - (svn-status-mouse-find-file-or-examine-directory): New command, bound
> > to mouse-2: just like svn-status-find-file-or-examine-directory
> > - (svn-status-mark-deleted): New command ,bound to '* D' to mark files
> > scheduled for deletion (similar to '* A' and '* M')
> > - (svn-status-mark-deleted): New command W bound to '* *' to mark files
> > modifed and files scheduled for addition and files scheduled for
> > deletion
> > - Moved "Mark" and "Unmark" to the "Mark/Unmark" submenu
> > - (svn-status-bury-buffer) Bury the *svn-log* buffer
> > - Modified a few docstrings
>
> I'm starting to have a problem with this. (I also have a problem keeping a
> nice tone in this mail.)
>
> On numerous occasions you have been asked to commit with HACKING compliant
> logs. C Mike told you to loose the dashes. Karl Fogel has told you to
> correct some old commit logs. Looking back at the history of psvn.el there
> are still an extreme number of non-compliant logs left. Correct this log.
> All non-compliant ones in the past would be nice.
>
> I really think you should start committing with compliant logs *now*. It's
> not really hard, you know: Othes have been doing it for years.
>
> bye,
>
> Erik.
>
> --
> NEU +++ DSL Komplett von GMX +++ http://www.gmx.net/de/go/dsl
> GMX DSL-Netzanschluss + Tarif zum supergŁnstigen Komplett-Preis!
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>
> --
> NEU +++ DSL Komplett von GMX +++ http://www.gmx.net/de/go/dsl
> GMX DSL-Netzanschluss + Tarif zum supergŁnstigen Komplett-Preis!
>
>
> --
> NEU +++ DSL Komplett von GMX +++ http://www.gmx.net/de/go/dsl
> GMX DSL-Netzanschluss + Tarif zum supergŁnstigen Komplett-Preis!
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Oct 31 02:21:41 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.