[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: r11556 causes enormous fsfs memory use

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2004-10-31 01:10:53 CEST

On Tue, 26 Oct 2004, Peter N. Lundblad wrote:

> On Mon, 25 Oct 2004, Eric Gillespie wrote:
>
> > Importing NetBSD src (822 MB, 89482 files, 10902 directories)
> > into an fsfs repository with svnserve 1.1.1, svnserve grows to
> > use 124 MB. The user who initially reported this to me saw it
> > bump into a 128 MB resource limit.
> >
> > I tracked this down to r11556. Undo that from a 1.1.1 working
> > copy, and the memory usage decreases back to 1.1.0 levels which,
> > while bad[1], were at least acceptable.
> >
> It apperas that apr_hash_set() allocates memory for each call that isn't a
> delete, even if there is an entry in the table already. We are using
> apr_hash_set to get and put back a translation handle for each translation
> (we don't want to do the translation while holding a global lock). So
> there we have an allocation per translation, which, ofcourse is
> unacceptable.
>
According to my tests, it looks like I pluggged the leak introduced by the
new utf8 caching in r11673. If you want to try it out, Eric, it would be
nice.

Prpposed for inclusion in 1.1.2.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Oct 31 01:01:19 2004

This is an archived mail posted to the Subversion Dev mailing list.