[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: pre commit hook changing the transaction

From: Torsten Curdt <tcurdt_at_apache.org>
Date: 2004-10-30 14:48:35 CEST

>You forget the last and most natural solution to use with Subversion:
>
>Since you have a global commit log, you essentially already have your
>changelog.
>
That's true ...but I much more verbose than required.
You don't want *each* commit in changelog. Besides
additional information like bugzilla references, who
supplied the patch, whether it was a fix or an addition
can only be stored inside the commit message as plain
text.

> If you write a pre-commit hook to scan for the required
>items and reject the commit if those are not in the log message, you
>can have the output from svn log as your changelog. See the svn log
>output for Subversion trunk/.
>
>
That would mean we require those magic tokens inside
the commit text. But that's not we want. We only like
to mark certain commits. "This one goes into the
change log" and provide structured data within the
commit message.

>>So my idea was to use a pre commit
>>hook to search the commit message for
>>the required information and add
>>them to the changelog file ..which
>>is under version control.
>>
>>
>
>I believe projects do this to compensate for CVS' lack of a global
>commit log. As such this way of thinking is an artifact of (years of)
>CVS use. With Subversion you don't need that anymore.
>
>
Well, I do think you have a point but I also think there
is a difference between a "commit log" and a "change log".
(see above)

>>But this means the pre commit hook
>>needs to change the transaction.
>>
>>Somewhere I read this is not (yet?)
>>possible.
>>
>>What's the status on that?
>>
>>
>
>It's not currently possible and not on any schedule to be addressed.
>Most Subversion developers feel that it's not ok for a server to
>change a committers contribution.
>
>
IMO it would be a valueable feature.

...but I can see the point why changing the
transaction might be considere dangerous
maybe the logging feature could be improved
instead?

The pre commit hook could parse the message

  CHANGELOG:
  BUG: 12434
  TYPE: FIX

  This fixes the bla problem

..and add additional structured data to the
commit log.

<logentry revision="26586" cl:type="changelog" cl:type="fix" cl:bug="12434">
  <author>cziegeler</author>
  <date>2003-12-05T13:59:01.000000Z</date>
  <msg>This fixes the bla problem</msg>
</logentry>

Then we could easily filter out the changelog
data. Although filtering on a "svn log" but be
even cooler.

This is just a RT (Random Thought) ...WDYT?

cheers

--
Torsten
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 30 14:45:34 2004

This is an archived mail posted to the Subversion Dev mailing list.