[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r11439 - trunk/subversion/libsvn_client

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2004-10-28 21:05:03 CEST

On Thu, 28 Oct 2004, Julian Foad wrote:

> Peter N. Lundblad wrote:
> > ------------------------------------------------------------------------
> > r11439 | lundblad | 2004-10-16 21:42:30 +0100 (Sat, 16 Oct 2004) | 6 lines
> >
> > Fix slow "svn st" where the targets are files by not locking the whole anchor
> > tree.
> >
> > * libsvn_client/status.c (svn_client_status): Don't lock the whole directory
> > hierarchy if not necessary.
>
> In the log message we give the path to each file relative to the root of the
> source tree - thus it should be "subversion/libsvn_client/status.c".
>
Hmmm, you're right. Interesting no one has complained before...

Also, this is what svn-log-message in Emacs svn-dev.el does for me. Anyone
knows why. I ahve my soruces in ~/src/svn/svn. Maybe others use another
convention?

> > + if (update)
> > + {
> [...]
> > + }
> > + else
> > + {
> [...]
> > + err = svn_wc_adm_open2 (&target_access, anchor_access, path,
> > + FALSE, (descend || update) ? -1 : 1, pool);
>
> The variable "update" is redundant in that test since it is known to be false.
>
True. I'll eliminate the whole special-case for the update case. It's not
necessary anymore according to earlier discussion.

Thanks for the review,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 28 20:57:25 2004

This is an archived mail posted to the Subversion Dev mailing list.