[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] bug in svn_ver_compatible?

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2004-10-28 00:51:36 CEST

Philip Martin <philip@codematters.co.uk> writes:

> Uwe Zeisberger <zeisberg@informatik.uni-freiburg.de> writes:
>
>> Index: subversion/libsvn_subr/version.c
>> ===================================================================
>> --- subversion/libsvn_subr/version.c (revision 11637)
>> +++ subversion/libsvn_subr/version.c (working copy)
>> @@ -48,7 +48,7 @@
>> else
>> /* General compatibility rules for released versions. */
>> return (my_version->major == lib_version->major
>> - && my_version->minor >= lib_version->minor);
>> + && my_version->minor <= lib_version->minor);
>> }
>
> One needs to look at this sort of code twice (at least!), but I think
> you are correct.

I committed it in r11640, with a modifed version of your regression
test. Thanks for the patch!

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 28 00:51:49 2004

This is an archived mail posted to the Subversion Dev mailing list.