Re: [PATCH] bug in svn_ver_compatible?

Uwe Zeisberger <zeisberg@informatik.uni-freiburg.de> writes:

> if I link a program to libsvn_something version 1.0.0 and then update to
> subversion 1.1.0 the program should continue to run, shouldn't it?

Yes.

> But in revision 11637, svn_ver_compatible(1.0.0, 1.1.0) returns FALSE.
>
> I think the last `>=' in svn_ver_compatible should be a `<='.

> Index: subversion/libsvn_subr/version.c
> ===================================================================
> --- subversion/libsvn_subr/version.c (revision 11637)
> +++ subversion/libsvn_subr/version.c (working copy)
> @@ -48,7 +48,7 @@
> else
> /* General compatibility rules for released versions. */
> return (my_version->major == lib_version->major
> - && my_version->minor >= lib_version->minor);
> + && my_version->minor <= lib_version->minor);
> }

One needs to look at this sort of code twice (at least!), but I think
you are correct.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org