Re: Possibly wrong string comparisons in SVN

Julian Foad wrote:

> Roland Ruedenauer wrote:
>
>> There seem to be some places in the SVN code where inadvertendly a
>> string prefix match is performed where a full match was desired.
>>
>> 1) libsvn_ra_local/split_url.c line 64
>>
>> if ((strncmp (hostname, "localhost", 9) != 0))
>
>
> Well caught. Thanks. I have confirmed this: "svn ls
> file://localhoster.collab.net/home/julianfoad/vcs/sandbox/" proceeds
> to list the contents of my local test repository.

Hmh! That should teach me to carefully look at the code (again -- I've
looked at that code quite a few times...) before answering.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 26 17:52:23 2004