[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Explicitly set PATH in the template hook scripts

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2004-10-19 18:55:06 CEST

On Tue, 2004-10-19 at 00:30, Peter S. Housel wrote:
> Following a discussion on #svn-dev, here is a patch to show the PATH
> environment variable being set explicitly in the hook script templates,
> alerting administrators to the fact that the passed-in environment can't
> necessarily be depended on.

I'm not sure if it's a good idea to assume that /bin:/usr/bin is a
decent path setting.

Perhaps SVN_BINARY_DIR ":$PATH" would be a better choice?

Also, if you don't "export PATH", you will get different behavior for
different implementations of /bin/sh, as far as whether the modified
value propagates to subprocesses. A POSIX shell will propagate the
modified value to subprocesses, but (for example) the Solaris /bin/sh
will propagate the old value.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 19 18:55:29 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.