On Tuesday 19 October 2004 18.00, Mark Benedetto King wrote:
> On Tue, Oct 19, 2004 at 10:54:18AM +0100, Joe Orton wrote:
> > On Mon, Oct 18, 2004 at 08:03:48PM +0200, Sigfred H??versen wrote:
> > > I've added a SSL layer to svnserve, and I would like to have some
> > > comments on the patch. Instructions how to run "make check" with
> > > self-signed certificate, is below.
> >
> > Bits of this code do look like they have been copied from neon e.g.
> > asn1time_to_string, but you have stripped the copyright notices.
> >
> > joe
>
> In reviewing this patch, it appears that several pieces of
> its functionality overlap with neon's SSL functionality.
>
> I think it would be best for Subversion to have only one
> implementation of things like asn1time_to_string, hostname/certificate
> matching, etc, so that they can be performed consistently.
>
> What do you think the best way to accomplish that would be?
>
>
> --ben
>
Subversion uses the Apache license, while Neon is essensially a LGPL layer on
top of OpenSSL. This was a major reason for not using Neon in my patch, as
well as not introduce an extra library (Neon, in this case). Besides, using a
BIO pair to handle the communication between svnserve/SSL and the network
made implementation much easier.
/Sigfred
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 19 18:50:18 2004