Re: Copied code report [was: Re: [PATCH] SSL layer for svnserve]

On Tue, 2004-10-19 at 06:36, Daniel Patterson wrote:
> Found 33 duplicate lines in the following files:
> Between lines 608 and 672 in subversion/libsvn_repos/delta.c
> Between lines 420 and 483 in subversion/libsvn_repos/reporter.c
>
> looks like someone moved the function but forgot to remove it.

The code in reporter.c is kind of a generalization of the code in
delta.c, but it also removed a bit of functionality (you can't use the
reporter.c code to diff a transaction against a transaction, only a
revision against a report-of-revisions). So it will take some tricky
design work to be able to combine them again. Sure, we could turn
compare_files() into a shared function since it's identical, but that
would be a drop in the bucket.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 19 17:08:37 2004