Copied code report [was: Re: [PATCH] SSL layer for svnserve]

Joe Orton wrote:
>
> Bits of this code do look like they have been copied from neon e.g.

   Speaking of copied code, I ran across a tool called Simian [1]
   the other day which does code similarity checking.

   I've attached the results (gzipped, hope it's not too big for
   this list (18k)), most of the interesting matches are near the
   end of the report. Unsurprisingly, there are lots of long
   matches in the fs_fs vs bdb areas. There are some other
   rather suspect looking entries though:

Found 33 duplicate lines in the following files:
  Between lines 608 and 672 in subversion/libsvn_repos/delta.c
  Between lines 420 and 483 in subversion/libsvn_repos/reporter.c

   looks like someone moved the function but forgot to remove it.

   Make of it what you will.

daniel

[1] http://www.redhillconsulting.com.au/products/simian/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org