[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Diffs into default log template

From: Chris Pepper <pepper_at_reppep.com>
Date: 2004-10-15 21:40:19 CEST

At 3:23 PM +0100 2004/10/14, Julian Foad wrote:
>Chris Pepper wrote:
>> This is neat, but since I'm working with docs instead of
>>functions, svnlog doesn't seem to get me anything more than "svn
>>diff | bbedit", which I've been using. I'd like something to dump
>>it into the log template, to save me a step.
>> I think what I really want would be a second loop in util.c,
>>after the list of files with status has been generated. If a (new)
>>flag was set, svn would loop across the files to be committed
>>again, appending a diff for each one on this round. It would be
>>cleaned out of the actual log message automatically, same as the
>>current list of files is ignored.
>> Would anyone else find this useful??
>I'm sure some people would find it of some utility, but the trouble
>is that the more "svn" tries to write your log message for you, the
>less people it will satisfy - either that, or it grows lots of
>options and configurability and becomes a generic log message writer
>trying to suit everybody.

        No, actually. I'm not asking for any changes to the default
log message itself, which would remain blank. Instead I'm asking for
an enhancement to the 'comment' area, below "--This line, and those
below, will be ignored--", which would not show up in the log
message, to help *humans* write log messages.

        It's my belief that more context here will encourage people
to confirm they're committing what they think, and make oversights in
the commit messages less likely.

>I don't think that Subversion should head in that direction. (I
>don't even think it should invoke an editor for you, but I seem to
>be in the minority there.) I recommend writing an external
>log-message-generator that suits your purposes, and put its name in
>the SVN_EDITOR environment variable so that Subversion calls it
>instead of a plain editor.
>If the log message utility that you write is neat and tidy and
>useful to lots of people, we could then include it as a tool in the
>Subversion distribution.

        Ugh. I'd have to start by patching the C code, either to
provide a local custom feature (which I think would be broadly
useful, but my query hasn't evoked any support for here...), or to
add a new 'hook' which would pass enough information to an external
program (probably a trivial shell script) to do the actual work. This
would be useful if lots of people wanted to tweak the helper comment
when writing logs with an interactive editor, but again I'm not sure
that's a good investment if there's a lack of interest (here), or how
many different options there are for customizing what is, after all,
an ephemeral comment.


Chris Pepper:               <http://www.reppep.com/~pepper/>
Rockefeller University:     <http://www.rockefeller.edu/>
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Oct 15 21:47:28 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.