[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r11400 - trunk/subversion/libsvn_delta

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2004-10-14 19:31:42 CEST

kfogel@collab.net writes:

> "C. Michael Pilato" <cmpilato@collab.net> writes:
> > Er. I'd feel much better about one of the following two solutions
> > over the one chosen:
> >
> > 1. Use conditional definition:
> >
> > #ifndef MIN
> > #define MIN(a, b) ((a) < (b) ? (a) : (b))
> > #endif
> >
> > And remove the #undef altogether.
> >
> > 2. Use SVN_MIN instead of TMP_MIN.
>
> Why?
>
> (Not arguing, just not seeing the problem.)

I think that when an environment is lacking a macro generally
available (or expected), simply adding that macro (with its expected
name) is a useful aid for developers. But if we insist on writing our
own macro, and if there exists a problem such that our definition or
undefinition of a macro can interfere with other macros of the same
name elsewhere, then I'd prefer we either use a macro name that is in
the SVN_ namespace. Those are my only reasons.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 14 19:34:06 2004

This is an archived mail posted to the Subversion Dev mailing list.