[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r11298 - branches/1.1.x

From: <kfogel_at_collab.net>
Date: 2004-10-13 06:03:11 CEST

Ben Reser <ben@reser.org> writes:
> These two paragraphs seem to contradict. Why would a vote with
> reservations be "+1 (concept)" when +1 means you throughly approve of
> the change. That doesn't make any sense. +0 makes far more sense for
> that. And I guess I'm missing the reservations or request for more
> information that follows up the "+1 (concept)" vote here.
>
> I think our historical usage has been more of +1, +0, -0, -1. But maybe
> I just never noticed the "+1 (concept) votes".

There have been "+1 (concept)" votes in the past, and we've understood
them not to be binding votes. I've always thought of "+1 (concept)"
as translating to "+1 on the concept, but I have some reservations
about the implementation (or about something)..."

Of course, the person has to then post, or say something in the Notes
field, to actually start a conversation about that. The word
"(concept)" alone won't have that effect.

If we get consistently confused by this, though, we could change to
just "+1" and "+0", since people can request more information whenever
they want anyway.

I'm, uh, +1 on doing that, as this isn't the first time there's been
confusion on this point. I'll wait a day to see if anyone objects
before editing HACKING.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 13 07:52:47 2004

This is an archived mail posted to the Subversion Dev mailing list.