[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r11298 - branches/1.1.x

From: Ben Reser <ben_at_reser.org>
Date: 2004-10-13 04:02:36 CEST

On Tue, Oct 12, 2004 at 07:14:27PM +0200, Peter N. Lundblad wrote:
> On Mon, 11 Oct 2004, Ben Reser wrote:
>
> > On Sat, Oct 09, 2004 at 03:48:47AM -0500, nori@tigris.org wrote:
> > > Modified: branches/1.1.x/STATUS
> > > Url: http://svn.collab.net/viewcvs/svn/branches/1.1.x/STATUS?view=diff&rev=11298&p1=branches/1.1.x/STATUS&r1=11297&p2=branches/1.1.x/STATUS&r2=11298
> > > ==============================================================================
> > > --- branches/1.1.x/STATUS (original)
> > > +++ branches/1.1.x/STATUS Sat Oct 9 03:48:43 2004
> > > @@ -26,6 +26,7 @@
> > > Regression and annoying for people using non-ASCII chars in log messages.
> > > Votes:
> > > +1: lundblad, brane
> > > + +1 (concept): nori
> >
> > Concept votes are +0. +1 means you've reviewed the patch in detail.
> >
> Not according to hacking.

Hmm, depends on which paragraph of HACKING you read:

>>>
Voting +1 on a change doesn't just mean you approve of it in principle.
It means you have thoroughly reviewed the change, and find it correct
and as nondisruptive as possible. When it is committed to the release
branch, the log message will include the names of all who voted for
it, as well as the original author and the person making the commit.
All of these people are considered equally answerable for bugs.

If you've reviewed a patch, and like it but have some reservations,
you can write "+1 (concept)" and then ask questions on the list about
your concerns. You can write "+0" if you like the general idea but
haven't reviewed the patch carefully. Neither of these votes counts
toward the total, but they can be useful for tracking down people who
are following the change and might be willing to spend more time on
it.
<<<

These two paragraphs seem to contradict. Why would a vote with
reservations be "+1 (concept)" when +1 means you throughly approve of
the change. That doesn't make any sense. +0 makes far more sense for
that. And I guess I'm missing the reservations or request for more
information that follows up the "+1 (concept)" vote here.

I think our historical usage has been more of +1, +0, -0, -1. But maybe
I just never noticed the "+1 (concept) votes".

-- 
Ben Reser <ben@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 13 04:02:49 2004

This is an archived mail posted to the Subversion Dev mailing list.