Re: [PATCH] HACKING: More language clean-up

Michael W Thelen wrote:
> Chris Pepper wrote:
>
>> * HACKING: Clean up more language nits.
>> s/commit-access/commit access/

Yes.

>> Include missing trailing slash on http://apr.apache.org (slashes are used
>> sometimes and skipped sometimes, but they *are* part of the real URL).

OK, though that's not as important as including the slash when the URL ends in a subdirectory. But since you're making other changes to this file you might as well fix this.

>> Clarify that the key for secure programming is developer understanding,
>> not necessarily further education.

I don't see that the meaning was unclear before. Not that your replacement is worse, but I don't see the need to change it. Surely it's obvious that if a developer has already been educated sufficiently in the subject, then this shouldn't be read as implying that he still needs more. This is aimed at new readers of the HACKING file, and it is reasonable to assume that most of them are not "educated" to the desired degree in this subject. Or maybe you don't like the word "education" because it implies a formal, structured activity, whereas any means of learning is of course acceptable.

I won't stop you changing it if you're sure that you are improving it, but I'm not sure.

>> Removed 'staked' from 'staked ownership', as it's neither formal nor
>> complete.

I don't understand your objection. What isn't formal or complete? The staking of ownership? This is talking about staking of ownership as a possible impression on a new reader, not as something that really existed. Note that "appears to have staked" is the verb phrase, and "ownership" the noun; were you reading it as "appears to have" and "staked ownership"? The wordings "appears to have staked ownership on the file" and "appears to have ownership of the file" mean effectively the same to me, but with the former (original) case additionally conveying the desired impression of "staking" being the writing of the "owner's" name in the file with intent to claim the file as his/her own.

So I disagree with this change.

>> Additional linguistic tweaks.

Yes. ("a" -> "an"; "can into" -> "can go into".)

- Julian

> Thanks for the patch. I've filed it as issue #2097:
> http://subversion.tigris.org/issues/show_bug.cgi?id=2097

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 12 16:11:06 2004