Danger of dereferencing null pointer

Hi,

when I was looking at subversion/clients/cmdline/util.c to comprehend
commit items I found the following lines of code:

  if (! (commit_items || commit_items->nelts))
    {
      *log_msg = "";
      return SVN_NO_ERROR;
    }

I believe the first line should be

if (!commit_items || !commit_items->nelts)

or

if (! (commit_items && commit_items->nelts) )

Otherwise if commit_item is NULL it will be dereferenced.

Regards Dirk

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 12 16:10:15 2004