lundblad@tigris.org writes:
> Log:
> Fix issue #2012, allow URI-encoded drive letter an colon or pipe character
> for ra_local URLs on Win32.
>
> * libsvn_ra_local/split_url.c (svn_ra_local__split_URL): URI-decode the path
> before checking for drive followed by : or |, so that this part can be
> URI_encoded.
The change looks good, but did you mean "and" instead of "an" in the
first line of your log message?
-Karl
> Modified: trunk/subversion/libsvn_ra_local/split_url.c
> Url: http://svn.collab.net/viewcvs/svn/trunk/subversion/libsvn_ra_local/split_url.c?view=diff&rev=11262&p1=trunk/subversion/libsvn_ra_local/split_url.c&r1=11261&p2=trunk/subversion/libsvn_ra_local/split_url.c&r2=11262
> ==============================================================================
> --- trunk/subversion/libsvn_ra_local/split_url.c (original)
> +++ trunk/subversion/libsvn_ra_local/split_url.c Wed Oct 6 15:53:59 2004
> @@ -85,18 +85,16 @@
> {
> static const char valid_drive_letters[] =
> "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";
> - /* ### What about URI-encoded drive letters? */
> - if (path[1] && strchr(valid_drive_letters, path[1])
> - && (path[2] == ':' || path[2] == '|')
> - && path[3] == '/')
> + char *dup_path = svn_path_uri_decode (path, pool);
> + if (dup_path[1] && strchr(valid_drive_letters, dup_path[1])
> + && (dup_path[2] == ':' || dup_path[2] == '|')
> + && dup_path[3] == '/')
> {
> - char *const dup_path = svn_path_uri_decode (++path, pool);
> + ++dup_path;
> if (dup_path[1] == '|')
> dup_path[1] = ':';
> - repos_root = dup_path;
> }
> - else
> - repos_root = svn_path_uri_decode (path, pool);
> + repos_root = dup_path;
> }
> #endif /* WIN32 */
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Oct 11 21:45:47 2004