[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Moved a misplaced #define

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2004-10-03 03:17:53 CEST

On Sat, 2004-10-02 at 17:00, Refael Ackermann wrote:
> There is/was a badly placed define in libsvn_delta/compose_delta.c
> It broke the build process for me (redefining #define MIN).
> I moved the #define into libsvn_delta/delta.h wrapped in #ifndef.

I can understand the #ifndef test, but why the move to delta.h?

> +#ifndef MIN /* Stiking in delta.c un-ifndef-ed is just wrong */
> +#define MIN(a, b) ((a) < (b) ? (a) : (b))
> +#endif

This comment won't make any sense to a reader unfamiliar with the
history of the code.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Oct 3 03:18:08 2004

This is an archived mail posted to the Subversion Dev mailing list.