Re: svn_repos_trace_node_locations()

Greg Hudson <ghudson@MIT.EDU> writes:

> I think it would be just fine to add "const" to the parameter, in a
> 1.x.0 release. All it does is make the function a little nicer. Issue
> #1952 is different because it's changing the expected signature of a
> callback ("your callback must be a little nicer").
>
> I know Philip raised some ABI concerns based on the C standard, but
> really, the C standard has little bearing on how API translates into
> ABI; that's up to the implementations. And implementations don't care
> what you declare const when determining ABIs.

If this were a C++ function then adding const would definitely break
the ABI. While I've never come across a C implementation that works
in the same way, I suppose it could be done. In my earlier message I
was careful to state that I didn't think there would be any ABI
problems on Linux, or the other Unix platforms I have used, and I
certainly won't object if the change is made.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org