Re: [PATCH] formatting dav human-readable errors

Ben Reser <ben@reser.org> writes:

> Can you actually give a transcript of an example of when you see this
> message.

Commit an out-of-date file.

$ svn ci foo
Committed revision N.
$ svn up -rN-1 foo
$ echo x >> foo
$ svn ci foo

> I guess I'm failing to understand your explanation of the
> problem you're solving. In your email you talk about the whitespace in
> the XML.

1. mod_dav_svn generates an error text.
2. mod_dav adds whitespace when writing the XML.
3. The client parses the XML and extracts the error text complete with
   whitespace.
4. The client creates an svn_error_t and copies the error text complete
   with whitespace.
5. The svn_error_t gets returned back up the call stack in the client.

I propose to remove the whitespace at step 4.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org