Re: [PATCH] formatting dav human-readable errors

On Tue, Sep 28, 2004 at 10:41:35PM +0100, Philip Martin wrote:
> Ben Reser <ben@reser.org> writes:
>
> > On Tue, Sep 28, 2004 at 09:30:14PM +0100, Philip Martin wrote:
> >> It's not XML, it's a change to the text stored in an svn_error_t. I
> >> guess that means I need a better log message!
> >
> > The fact that it's in svn_error_t doesn't mean it's not XML. The errors
> > we return via DAV are XML and that's what this is. But that presents a
> > further argument as to why it's not part of our API...
>
> This is client side; it's all happening in the client's address space.
> The XML that comes from the server has already been parsed, that's not
> changing, all that's changing is an svn_error_t that gets returned up
> the call stack in the client.

Can you actually give a transcript of an example of when you see this
message. I guess I'm failing to understand your explanation of the
problem you're solving. In your email you talk about the whitespace in
the XML.

Now that I look at your patch more careful I guess you're skipping over
printing the whitespace that just gets acquired from the XML. Is that
the case? If so what exactly does it look like from the command line
client when you get this problem?

-- 
Ben Reser <ben@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org