[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Don't reinstall include files if identical files are already installed

From: Sven Mueller <sm_at_leogic.com>
Date: 2004-09-20 14:37:13 CEST

Greg Hudson [u] wrote on 19/09/2004 00:31:

> On Sat, 2004-09-18 at 17:30, David James wrote:
>>* build/generator/gen_make.py
>> (gen_make.Generator.write): Don't reinstall include files if
>>identical files are already installed.
> I checked a few random library packages (openssl, libpng) and they
> install their header files unconditionally. automake-generated
> Makefiles also install their header files unconditionally. I don't
> think it's really incumbent upon us to only install header files if
> they've changed, and we shouldn't complicate our build system in order
> to do so.
> Also, your implementation would fail to install the headers in
> situations where it really should. If I built and installed svn-1.0.7
> today, and then went and grabbed 1.1.0-rc3 and built and installed it, I
> would fail to install the header files with your implementation, because
> the mod times from today's install of 1.0.7 would be newer than the mod
> times of the headers from the 1.1.0-rc3 tarball.

Install-Targets should always depend on the _sources_ (not in the
meaning of source codes, but source of a copy) it wants to install.
"install-bin" should depend on "bin"
However, it should _not_ under any circumstance depend on the targets it
wants to install _to_.
"install-bin" should not depend on /usr/bin/svn
instead, install* should be "PHONY" targets.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 20 14:37:34 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.