[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Don't reinstall include files if identical files are already installed

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2004-09-19 00:31:10 CEST

On Sat, 2004-09-18 at 17:30, David James wrote:
> * build/generator/gen_make.py
> (gen_make.Generator.write): Don't reinstall include files if
> identical files are already installed.

I checked a few random library packages (openssl, libpng) and they
install their header files unconditionally. automake-generated
Makefiles also install their header files unconditionally. I don't
think it's really incumbent upon us to only install header files if
they've changed, and we shouldn't complicate our build system in order
to do so.

Also, your implementation would fail to install the headers in
situations where it really should. If I built and installed svn-1.0.7
today, and then went and grabbed 1.1.0-rc3 and built and installed it, I
would fail to install the header files with your implementation, because
the mod times from today's install of 1.0.7 would be newer than the mod
times of the headers from the 1.1.0-rc3 tarball.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Sep 19 00:31:24 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.