On Thu, 9 Sep 2004, Greg Hudson wrote:
> On Wed, 2004-09-08 at 17:37, Peter N. Lundblad wrote:
> > Also, I had to move the call of svn_Utf_initialize out of
> > svn_cmdline_initialize, since we don't have a pool there.
>
> It should be fine to create a pool in svn_cmdline_initialize. A program
> dynamically loading and unloading the svn libraries won't use that
> function.
>
Goodi point. Is guaranteed somewhere or just a reasonable assuptiion?
> > I haven't added
> > it to svnserve, since it creates detached threads and I don't know how to
> > guarantee that they are done before the cleanup of the pool, which is a
> > requirement.
>
> I'm not sure where your concern arises from that the pool in main()
> might be cleaned up before the detached threads terminate. As far as I
> can tell, we never clean up that pool, because the main loop never
> terminates.
>
It will be fixed if the above is changed.
Did you look at the patch in itself?
Thanks,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 9 21:09:02 2004