Re: [PATCH] Re: svn_utf_initialize and pool cleanup

On Wed, 2004-09-08 at 17:37, Peter N. Lundblad wrote:
> Also, I had to move the call of svn_Utf_initialize out of
> svn_cmdline_initialize, since we don't have a pool there.

It should be fine to create a pool in svn_cmdline_initialize. A program
dynamically loading and unloading the svn libraries won't use that
function.

> I haven't added
> it to svnserve, since it creates detached threads and I don't know how to
> guarantee that they are done before the cleanup of the pool, which is a
> requirement.

I'm not sure where your concern arises from that the pool in main()
might be cleaned up before the detached threads terminate. As far as I
can tell, we never clean up that pool, because the main loop never
terminates.

(If we ever want to add graceful termination to svnserve, we'll have to
join the detached threads, I think; otherwise we won't be able to call
apr_terminate().)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 9 19:16:51 2004