[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 1.1rc1 performance regression in 'svn status'

From: Branko Čibej <brane_at_xbc.nu>
Date: 2004-08-05 13:24:30 CEST

Peter N. Lundblad wrote:

>On Wed, 4 Aug 2004, Matt Doran wrote:
>
>
>
>>SVN 1.0.6: ~ 4 secs
>>SVN 1.1rc1: ~ 38 secs !!
>>
>>I used the Filemon utility from sysinternals to try to determine what it
>>happening. It looks like 1.1 excessively hits 'iconv' files. (e.g.
>>windows-1252.so, utf-8.so, etc)
>>
>>
>>
>I did some more checking in GDB. It appears that apr_xlate_open gets
>called 4312 times out of 17204 calls to get_xlate_handle (in
>libsvn_subr/utf.c).
>This was during a run of "svn st" on trunk. This caching strategy needs to
>be improved.
>
>
That's a 75% hit rate, which -- given our constraints -- isn't all that
bad. The problem is that we can only safely cache the xlate handle in
the current pool. If that happens to be a subpool in some loop -- well,
tough luck.

>I don't know why it is faster on 1.0, though.
>
>
We probably fixed some pool usage bugs in the meantime, and those fixes
happened to narrow the scopes of some xlate handles.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 5 13:25:24 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.