Re: 1.1rc1 performance regression in 'svn status'

On Thu, 5 Aug 2004, [UTF-8] Branko Ä^Libej wrote:

> Peter N. Lundblad wrote:
>
> >When we use iconv, we cache the iconv handle in the current pool. I guess
> >we are doing some charset encoding in a loop with a subpool that gets
> >cleared or something.
> >
> >Couldn't we used thread-specific data for this instead?
> >
> No, because we have no way to initilize it, since we have neither
> library initializers nor a context parameter for each function.
>
Was thinking of apr_thread_once. Then I discovered apr_thread_once_init.
What's the point of thread_once if it needs to be initialized exactly
once? Is there nothing corresponding to PTHREAD_ONCE_INIT?

> The only problem is that you can't initialize it sanely if you're not
> controlling thread creation. See apr_thread_proc.h.
>
*sigh*

OK, the current caching is an improvement, but not enough since apr_iconv
doesn't do caching. Too bad.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 5 09:11:11 2004